8000 Build and upload images with GH actions by shabani1 · Pull Request #98 · lexy-ai/lexy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Build and upload images with GH actions #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
May 7, 2024
Merged

Build and upload images with GH actions #98

merged 38 commits into from
May 7, 2024

Conversation

shabani1
Copy link
Contributor
@shabani1 shabani1 commented May 7, 2024

What

Added action to build images and upload them to GH Container Registry.

  • Images are built when tags are pushed
    • Built for arm64 and amd64
  • Images built outside of development now include installs of lexy and lexy-py
  • Fixed poetry install inside of dockerfiles
  • Added other performance improvements within dockerfiles
  • Moved many default vars to dockerfile so that third-parties can minimize their docker-compose.yml

Why

Developers no longer need to rely on Lexy code, and can build on top of base images.

Test plan

  • Run make run-tests and verify that all tests pass
  • Run examples/tests.ipynb and verify that there are no errors
  • Run examples/images.ipynb and verify that the tutorial works as expected

shabani1 and others added 30 commits April 29, 2024 15:48
@shabani1
Testing actions
ce2eb9d
@shabani1
Update docker-publish.yml
b79092c
@shabani1
Update docker-publish.yml
736fd11
@shabani1
Update docker-publish.yml
7d94467
@shabani1
Update contributing.md
1d6a92f
@shabani1
Update docker-publish.yml
e2c509c
@shabani1
Update docker-publish.yml
57dd66e
@shabani1
Update docker-publish.yml
66f58dd
@shabani1
Update docker-publish.yml
5a8618c
@shabani1
Update docker-publish.yml
c8b2518
@shabani1
Update docker-publish.yml
f1d2049
@shabani1
Update docker-publish.yml
2050b27
@shabani1
Update docker-publish.yml
adef1e4
@shabani1
Update docker-publish.yml
fdffb5f
@shabani1
Update docker-publish.yml
313e3b7
@shabani1
Update docker-publish.yml
466074b
@shabani1
Update docker-publish.yml
d537e50
@shabani1
Update docker-publish.yml
945d849
@shabani1
Update docker-publish.yml
1c76d6c
@shabani1
Update docker-publish.yml
b2c1118
@shabani1
Update docker-publish.yml
c0a619b
@shabani1
Update docker-publish.yml
ef9e655
@shabani1
Update docker-publish.yml
588ba91
@shabani1
Update docker-publish.yml
4241dc0
@shabani1
Update docker-publish.yml
4d6034c
@shabani1
Update docker-publish.yml
edd8f76
@shabani1
Cleaning
16188cc
@shabani1
switch to building on push tag
d20a284
@shabani1
switch to production build
945aefa
@shabani1
debugging poetry install
0f84e5a
@shabani1 shabani1 merged commit 188708d into main May 7, 2024
3 checks passed
@shabani1 shabani1 deleted the rs/test-gh-actions branch May 7, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shabani1
0