Collection names and UIDs #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
collection_nameinstead ofcollection_idcollection_idwill now contain a short UID generated for each collectioncollection_idandcollection_namecollections/{collection_id}/documentsWhy
This allows proper CRUD using unique identifiers for collections. We can now change collection names, and use unique collection IDs for storing files in S3/GCS/Azure paths.
Test plan
make run-testsand verify that all tests passexamples/tests.ipynband verify that there are no errorsexamples/images.ipynband verify that the tutorial works as expectedMiscellaneous
This PR contains changes to DB schema - easiest way is to drop and recreate your tables. Otherwise you need to run a migration (not provided here because other fields will soon change).