8000 Allow document_id to be passed when creating new documents by shabani1 · Pull Request #50 · lexy-ai/lexy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow document_id to be passed when creating new documents #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

Allow document_id to be passed when creating new documents #50

merged 1 commit into from
Jan 31, 2024

Conversation

shabani1
Copy link
Contributor
@shabani1 shabani1 commented Jan 31, 2024 •
edited
Loading

What

Addresses #48

  • Added UUID as optional to DocumentCreate model.
  • Included tests for adding duplicate docs.
  • Added an emoji logo and favicon (I know it should be separate PR, but whatevs).

Why

The server was ignoring values for document_id in the add_documents endpoint. This resulted in the ability to add duplicate documents.

Test plan

  • Run pytest sdk-python
  • Run examples/tests.ipynb and verify that there are no errors
  • Run examples/tutorial.ipynb and verify that the tutorial works as expected
  • Run examples/images.ipynb and verify that the tutorial works as expected

@shabani1 shabani1 linked an issue Jan 31, 2024 that may be closed by this pull request
[BUG] Python client can add duplicate documents to a collection #48
Closed
@shabani1 shabani1 merged commit 3d0653a into main Jan 31, 2024
@shabani1 shabani1 deleted the rs/bugfix-add-duplicate-docs branch January 31, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Python client can add duplicate documents to a collection
1 participant
@shabani1
0