8000 Improved testing by shabani1 · Pull Request #56 · lexy-ai/lexy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improved testing #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Improved testing #56

merged 1 commit into from
Feb 14, 2024

Conversation

shabani1
Copy link
Contributor

What

Running pytest lexy_tests now uses the test DB via dependency overrides.

Still have a long ways to go for full test suite.

  • Client tests still use the normal DB, need to switch them over
  • Need to refactor IndexManager and Celery to use session dependencies

Why

Without using the test DB, it's difficult to test things like creating new indexes and bindings.

Test plan

  • Run pytest sdk-python make run-tests
  • Run examples/tests.ipynb and verify that there are no errors
  • Run examples/tutorial.ipynb and verify that the tutorial works as expected
  • Run examples/images.ipynb and verify that the tutorial works as expected

@shabani1 shabani1 merged commit 56889e2 into main Feb 14, 2024
@shabani1 shabani1 deleted the rs/improved-testing branch February 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0