8000 Bugfix for postgres host in GlobalConfig by shabani1 · Pull Request #43 · lexy-ai/lexy · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugfix for postgres host in GlobalConfig #43

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

Bugfix for postgres host in GlobalConfig #43

merged 1 commit into from
Jan 10, 2024

Conversation

shabani1
Copy link
Contributor

What

  • Previously running alembic upgrade head without exporting POSTGRES_HOST=localhost would cause an error.
  • Can now run this command locally, and should no longer need to configure IDE or notebooks with a POSTGRES_HOST environment variable.

Why

POSTGRES_HOST was defaulting to db_postgres instead of localhost, which is the value set inside of docker.

Test plan

  • Run pytest sdk-python
  • Run examples/tests.ipynb and verify that there are no errors
  • Run examples/tutorial.ipynb and verify that the tutorial works as expected
  • Run examples/images.ipynb and verify that the tutorial works as expected

@shabani1 shabani1 merged commit 116ecc9 into main Jan 10, 2024
@shabani1 shabani1 deleted the rs/bugfix-postgres-host branch January 10, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shabani1
0