8000 A few fixes on paths when crosscompiling from macOS by alkama · Pull Request #7 · leifo/haujobb-amiga · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

A few fixes on paths when crosscompiling from macOS #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

A few fixes on paths when crosscompiling from macOS #7

wants to merge 11 commits into from

Conversation

alkama
Copy link
@alkama alkama commented Feb 15, 2019

Hello,
I only tested cross-compiling on macOS.

  • I noticed that a few of the makefiles are targeting windows path like "c:", so I'm changing them to adopt the $VBCC environment variable.
  • With typical install of VBCC with m68k-amigaos, it appears "clib/exec_protos.h" is only found if using the NDK39 (unzipped at the $VBCC location). So i added the includes to its headers in the demos that require it.
  • The demo screenmodes was complaining about the first structure in "wos/wos.h", I figured it should probably be compiled as c99 (like the other demos). Compiles correctly (even if this demo produces garbage except for mode 13 in FS-UAE).

Hopefully those fixes wont break for other environments :D

@alkama
Copy link
Author
alkama commented Feb 17, 2019

All demos are now compiling and running fine on QtCreator on macOS, except for hellodemo that needs more work on BASS and libraries :D

@leifo
Copy link
Owner
leifo commented Feb 22, 2019

Thanks Alkama! Only noticed this now. Will test it as soon as I can.

@alkama
Copy link
Author
alkama commented Mar 4, 2019

No worries :D take your time! and do not hesitate to tell me what you want to keep or reject (like my introduction of "WOS_ON_PC" global define). Or if you want me to squash those commits to one.
I split them in different ones so that it's easier to see what fixed what :D

By the way, tiny question, is there a reason you use & instead of && for example in https://github.com/leifo/haujobb-amiga/blob/master/demo/stars/src/starseffect.c#L85 or https://github.com/leifo/haujobb-amiga/blob/master/demo/stars/src/starseffect.c#L87 ?
It seems that using && would make sense and generates less asm instructions while running faster in my emulator, but maybe I'm totally wrong and missing something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkama @leifo
0