feat: [WIP] Persistent env extension custom types #3687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PersistentEnvExtensiontype required that the data stored in an .olean file for the extension was of typeArray αfor someα, even thoug 8000 h it did not really take advantage of this structure at all (except for requiring that it has a default value, for slightly dubious reasons). This PR generalizes it to allow any type, in case the extension wants to e.g. store a per-file HashMap or RBMap directly in the olean instead of an array.Breaking changes (metaprogramming only):
PersistentEnvExtension α β σare nowPersistentEnvExtension (Array α) β σ. Other extension variants are not affected.