fix: deprecation span should only cover the ident #2459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce7d682 to
78fa61a
Compare
|
LGTM but could you add a brief comment as to what the new test is testing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
foois deprecated then the entiresimp [foo]cal 8000 l would be highlighted. This causes issues for a linter I am writing which requires that the warning just cover the identifier, as well as just being generally confusing for the user if there are many identifiers in thesimpcall.simpis not the only affected tactic, many functions callresolveId?without setting the ref first. An alternative solution would be to haveLinter.checkDeprecatedtake a syntax directly instead of using the ref, but there are also some other errors that identifier resolution can throw which are subject to the same issue.