chore: use binderIdent consistently in grammar #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR normalizes usage of
binderIdentvsidentacross the lean grammar. To construct this PR I reviewed every occurrence ofidentto determine whether (1) it is introducing a new binding and (2) it would make sense to be allowed to use_with the meaning of introducing an unnamed (hygienic automatically named) variable, especially in cases where the unused variables linter might fire.Currently the PR does not compile because there will be some staging and other bugfixing regarding the use and implementation of the
_part of these commands. Before proceeding I would like a thumbs-up regarding all (or a subset of) the grammar changes proposed here. In the examples below each occurrence of_xrepresents anidentthat would be allowed to be_under the proposal.{ _x // e }by intros _xby rename a => _xby injection e with _xby injections _xby have' _x := eby generalize _x : e = _xby cases _x : etermination_by' _x => edecreasing_by _x => tacinitialize _x : e <- enotation "foo" _x => emacro "foo" _x:cat : cat => ematch _x : e with | _x@pat => elet _x y := e; ehave _x y := e; eAdditionally, places which used
ident <|> holefor binders were changed to usebinderIdent. This decreases the amount of ad-hoc special casing required in programs consuming and constructing lean syntax like mathport. (Unfortunately there is still some conversion required to go frombinderIdenttoterm, since the_case is represented differently in each case.)