8000 fix: highlight keywords when keyword is actual identifier by mhuisi · Pull Request #9019 · leanprover/lean4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: highlight keywords when keyword is actual identifier #9019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: highlight keywords when keyword is actual identifier #9019

wants to merge 1 commit into from
+2 −2

Conversation

mhuisi
Copy link
Contributor
@mhuisi mhuisi commented Jun 26, 2025 •
edited
Loading

This PR fixes a bug where semantic highlighting would only highlight keywords that started with an alphanumeric character. Now, it uses Lean.isIdFirst.

@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Jun 26, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 26, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9bf5fc2fd3771291589a95e764d5b1fce02927b7 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force Mathlib CI using the force-mathlib-ci label. (2025-06-26 15:01:27)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-server Language server, widgets, and IDE extensions toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhuisi @leanprover-community-bot
0