feat: add lean_setup_libuv for initializing required LIBUV components
#8636
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mathlib CI status (docs):
|
|
This presumably makes progress on #5819 ? |
Not exactly, LibUV provides some functions like |
zwarich
reviewed
Jun 12, 2025
zwarich
approved these changes
Jun 14, 2025
zwarich
reviewed
Jun 14, 2025
eric-wieser
reviewed
Jun 14, 2025
TwoFX
approved these changes
Jun 25, 2025
Co-authored-by: Markus Himmel <markus@lean-fro.org>
…into sr/setup-libuv
eric-wieser
reviewed
Jun 26, 2025
eric-wieser
reviewed
Jun 26, 2025
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…into sr/setup-libuv
eric-wieser
reviewed
Jun 26, 2025
doc/dev/ffi.md
Outdated
| @@ -131,14 +131,21 @@ Thus `[init]` functions are run iff their module is imported, regardless of whet | |||
|
|
|||
| The initializer for module `A.B` is called `initialize_A_B` and will automatically initialize any imported modules. | |||
| Module initializers are idempotent (when run with the same `builtin` flag), but not thread-safe. | |||
|
|
|||
| **Important for process-related functionality**: If your application needs to use process-related functions from libuv, such as `getProcessTitle` and `setProcessTitle`, you must call `lean_setup_libuv(argc, argv)` (which returns a potentially modified `argv` that must be used in place of the original) **before** calling `lean_initialize()` or `lean_initialize_runtime_module()`. This sets up libuv's process handling capabilities correctly, as it internally invokes `uv_setup_args`, which is essential for certain system-level operations that Lean's runtime may depend on. | |||
There was a problem hiding this comment.
Is getProcessTitle a lean function name? What namespace is it in?
There was a problem hiding this comment.
It's going to be added in #8072. It's in the Std.Internal.IO.Process namespace.
There was a problem hiding this comment.
Wrong PR? That's about DNS
There was a problem hiding this comment.
Oh, sorry it's #8109.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function called
lean_setup_libuvthat initializes required LIBUV components. It needs to be outside oflean_initialize_runtime_modulebecause it requiresa 8000 rgvandargcto work correctly.