feat: BaseIO.joinTask
#8070
Open
feat: BaseIO.joinTask
#8070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 24, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2025
|
Mathlib CI status (docs):
|
|
!bench |
|
Here are the benchmark results for commit 6e1436e. Benchmark Metric Change
================================================================================
- Init.Data.List.Sublist re-elab -j4 maxrss 9.2% (149.1 σ)
+ big_do task-clock -4.1% (-16.5 σ)
+ big_do wall-clock -4.1% (-11.3 σ)
+ bv_decide_large_aig.lean branch-misses -1.5% (-24.5 σ)
- channel.lean bounded0_spsc 15.2% (13.6 σ)
+ lake build clean task-clock -1.6% (-16.1 σ)
+ lake build clean wall-clock -2.2% (-16.4 σ)
+ omega_stress.lean async branch-misses -2.0% (-11.0 σ)
+ stdlib attribute application -2.4% (-12.9 σ)
+ stdlib blocked -3.1% (-60.1 σ)
+ stdlib blocked (unaccounted) -2.8% (-12.1 σ)
+ stdlib instantiate metavars -4.3% (-10.8 σ)
+ stdlib process pre-definitions -3.8% (-77.7 σ)
+ stdlib tactic execution -2.7% (-34.0 σ)
+ stdlib task-clock -2.9% (-573.4 σ)
+ stdlib type checking -3.6% (-19.7 σ) |
|
!bench |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
!bench |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Apr 25, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 25, 2025
|
Here are the benchmark results for commit 94f6ae6. Benchmark Metric Change
==================================================================
- Init.Data.List.Sublist re-elab -j4 maxrss 9.4% (20.5 σ)
+ bv_decide_mul maxrss -2.0% (-59.9 σ)
- lake build no-op wall-clock 13.8% (13.5 σ)
+ liasolver task-clock -1.4% (-31.2 σ)
+ liasolver wall-clock -1.4% (-35.0 σ)
+ qsort task-clock -4.2% (-19.5 σ)
+ qsort wall-clock -4.2% (-19.7 σ)
- workspaceSymbols task-clock 2.7% (16.0 σ)
- workspaceSymbols wall-clock 2.7% (16.0 σ) |
|
!bench |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jun 1, 2025
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jun 1, 2025
|
Here are the benchmark results for commit 39aaa68. Benchmark Metric Change
=========================================================
+ channel.lean maxrss -2.6% (-23.7 σ)
+ liasolver maxrss -2.6% (-70.6 σ)
+ nat_repr maxrss -2.5% (-92.0 σ)
+ qsort maxrss -2.6% (-70.6 σ)
+ stdlib process pre-definitions -1.5% (-20.6 σ) |
|
What is the greater context here? Is it measurable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
BaseIO.joinTask act prio, an optimized version of(<- act.asTask prio).bind id.