8000 chore: remove instBEqNat, which is redundant with instBEqOfDecidableEq but not defeq by kim-em · Pull Request #5694 · leanprover/lean4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove instBEqNat, which is redundant with instBEqOfDecidableEq but not defeq #5694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 16, 2024
Merged

chore: remove instBEqNat, which is redundant with instBEqOfDecidableEq but not defeq #5694

merged 5 commits into from
Oct 16, 2024

Conversation

kim-em
Copy link
Collaborator
@kim-em kim-em commented Oct 14, 2024

No description provided.

@kmill
Copy link
Collaborator
kmill commented Oct 14, 2024

I think there are a number of things that assume == is Nat.beq, which has special kernel support. At least Nat.decEq is defined in terms of Nat.beq, but, still, I worry about whether this will have other effects.

There's a big change I've wanted to see, which is to redefine Decidable (#2038). That way we could solve this at the root and make them just be defeq. I found a definition that's not so invasive too.

@kim-em kim-em requested a review from leodemoura as a code owner October 14, 2024 02:14
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 14, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 14, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5694
5742b12
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 14, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5694
06079d2
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Oct 14, 2024
@leanprover-community-bot
Copy link
Collaborator
leanprover-community-bot commented Oct 14, 2024 •
edited
Loading

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 14, 2024
@kim-em
fixes for leanprover/lean4#5694
98aa962
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 14, 2024
@kim-em
fix test for leanprover/lean4#5694
6694638
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Oct 14, 2024
@kim-em
Copy link
Collaborator Author
kim-em commented Oct 14, 2024

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit dddcef8.
There were significant changes against commit 1d8555f:

  Benchmark   Metric   Change
  =======================================
+ stdlib      dsimp     -1.0% (-1036.3 σ)

@kim-em kim-em enabled auto-merge October 15, 2024 08:25
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5694
e8c146e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5694
cd42001
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 16, 2024 04:40 Inactive
@kim-em kim-em added this pull request to the merge queue Oct 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5694
2d87b4e
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5694
43a210e
Merged via the queue into master with commit a04b476 Oct 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kim-em @kmill @leanprover-community-bot @leanprover-bot
0