feat: warnings for commands that do not have desired effects in particular contexts #4892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a syntax ref to `Command.Scope` to keep track of what is responsible for adding it. In the future, this syntax ref could be used to include links to `section`/`namespace` commands in `end`'s errors. For now, these are used by `end` to determine whether scopes were added by `section` or `namespace` for further validation. Adds tests for the `end` command. Removes the unused `Lean.Elab.Command.withNamespace`.
|
@Kha Here's a draft for making it so commands can see whether global or local effects are expected. It's a bit different from what we discussed since it was easier this way to take advantage of incrementality for macros. |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 1, 2024
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
$cmd1 in $cmd2combinator is implemented assection $cmd1 $cmd2 end, which means that if$cmd2has local effects (like a@[local simp]attribute) then the command apparently has no effects at all. Now$cmd2can detect it is in such a context and log a warning in such cases. Similarly,$cmd1can detect it is in a context where global effects are not welcome.Also, this adds a
reffield toCommand.Scopeto keep track of what was responsible for the scope. In the future, this syntax ref could be used to include links tosection/namespacecommands inend's errors. For now, these are used byendto determine whether scopes were added bysectionornamespacefor further validation. In particular, this is used to raise errors in constructions such ascmd1 in namespace foo,cmd1 in end, orend in cmd2.Adds tests for the
endcommand. Removes the unusedLean.Elab.Command.withNamespace.Closes #4744, closes #4743