Fix NoSuchMethod exception for HelperSHA256 on API Level prior to P #1117 8000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On devices running older than Android Pie, an exception will be raised when using Helper.SHA256 method.
What is the new behavior?
Now code has been splitted so newer versions will run curent code, while older ones will run the patched one.
Other information
An instrumented test has been added. I was unable to test it on an emulator. Running the test on my physical Android 8.1 (Oreo MR1) device, it is now working as expected.
To run the instrumented test, open the "tests" view on the Project sidebar tab, an click the "Run" icon on the HelperTest.java on the androidTest folder.