Fix floating wallet/rewards bar for RTL layout #1044
Conversation
|
Could you use descriptive commit messages for what they do instead of what fixes on the GitHub repository? Thanks. |
|
@kekkyojin |
Problem is GitHub only shows first paragraph of commit message. Also, when looking at the Annotate feature on Android Studio or doing a 'git log', it will be needed to read a longer text when searching for a specific change explanation. I suggest you to at least put the descriptive change into the first paragraph and then anything else.
No, it was not necessary. |
7efbfcc to
d9891f8
Compare
|
Commit message is now descriptive first, referencing issue second - thus showing fine in git log and android studio. |
Floating wallet balance/rewards now visible in RTL layout
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
Issue Number: #1043
What is the current behavior?
Floating wallet fragment pinned to the bottom right of the screen (regardless of layout direction)
Floating wallet fragment does not display wallet balance on RTL layout
What is the new behavior?
Floating wallet fragment pinned to the bottom end of the screen - generalized LTR/RTL solution
Floating wallet fragment now displays both rewards and balance
Screenshots
LTR layout after fix
Not modified
RTL layout after fix
Fixed
Disclaimer
I swear I'm not splitting every little RTL issue to separate PR's
I'm genuinely finding them one at a time 🤷