Enabling monitoring/probing of Vars and OutPorts of processes with Monitor Process #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…litate for accessing extra proc param in proc model
� Conflicts: � src/lava/magma/compiler/builder.py � src/lava/magma/compiler/compiler.py � src/lava/magma/core/model/interfaces.py � src/lava/magma/core/model/py/model.py � src/lava/magma/core/model/py/ports.py � src/lava/magma/core/process/ports/ports.py � src/lava/magma/runtime/runtime_service.py � tests/lava/magma/compiler/test_compiler.py � tests/lava/magma/core/model/test_py_model.py � tests/lava/magma/core/process/test_ports.py � tests/lava/magma/runtime/test_ref_var_ports.py
PhilippPlank
requested changes
Nov 23, 2021
mathisrichter
requested changes
Nov 23, 2021
|
@elvinhajizada Please make sure to push your resolving changes to the PR before you mark conversations as resolved. |
|
@mathisrichter I was making changes while resolving conversations to not lose track of what I have resolved |
|
@mathisrichter and @PhilippPlank your requested changes are addressed. Please have a look and approve if it is all right |
PhilippPlank
approved these changes
Nov 24, 2021
mathisrichter
pushed a commit
that referenced
this pull request
Dec 1, 2021
* - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * First test and empty src files for Monitor proc * Tests for preliminary Monitor proc/-model; adding prom_params to facilitate for accessing extra proc param in proc model * Preliminary Monitor proc/-model for one proc, one var/output monitoring * Monitor proc/-model for monitoring one Var or OutPort of one proc * Adapting Monitor tests to changes in LIF proc * Addressing requested changes in PR#80 * Addressed change requests from PR #80 * Probing multi-dim vars, probe data convention changed, deprecation warnings for float fixed * Fix for flake8 Co-authored-by: PhilippPlank <philipp.plank@intel.com> Co-authored-by: PhilippPlank <32519998+PhilippPlank@users.noreply.github.com>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * First test and empty src files for Monitor proc * Tests for preliminary Monitor proc/-model; adding prom_params to facilitate for accessing extra proc param in proc model * Preliminary Monitor proc/-model for one proc, one var/output monitoring * Monitor proc/-model for monitoring one Var or OutPort of one proc * Adapting Monitor tests to changes in LIF proc * Addressing requested changes in PR#80 * Addressed change requests from PR lava-nc#80 Co-authored-by: PhilippPlank <philipp.plank@intel.com>
monkin77
pushed a commit
to monkin77/thesis-lava
that referenced
this pull request
Jul 12, 2024
* - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * - Initial enablement of RefPort and VarPorts * First test and empty src files for Monitor proc * Tests for preliminary Monitor proc/-model; adding prom_params to facilitate for accessing extra proc param in proc model * Preliminary Monitor proc/-model for one proc, one var/output monitoring * Monitor proc/-model for monitoring one Var or OutPort of one proc * Adapting Monitor tests to changes in LIF proc * Addressing requested changes in PR#80 * Addressed change requests from PR lava-nc#80 * Probing multi-dim vars, probe data convention changed, deprecation warnings for float fixed * Fix for flake8 Co-authored-by: PhilippPlank <philipp.plank@intel.com> Co-authored-by: PhilippPlank <32519998+PhilippPlank@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes enables monitoring
VarsandOutPortsof given process. This is done through Monitor process (implemented here) which dynamically creates newRefPortsandInPortsto monitorVarsandOutPorts, respectively. Each probing also creates a data-stroringVar. Once run is finished, collected data is structured intodataattribute of Monitor process. Stored data from specificVars/OutPortsof a given Process can be accessed by their names indatadict.Limitations:
VarorOutportof single process.Note: The infrastructure for multi-variable monitoring is mostly implemented and is part of this pull request, however one-to-one correspondence requirement between Process and ProcessModel in terms of LavaPyTypes and Ports, blocks usage of this infrastructure for now.