8000 Sigma delta neuron, encoding and decoding support by bamsumit · Pull Request #180 · lava-nc/lava · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Sigma delta neuron, encoding and decoding support #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 24, 2022
Merged

Sigma delta neuron, encoding and decoding support #180

merged 11 commits into from
Feb 24, 2022

Conversation

bamsumit
Copy link
Contributor

Issue Number:

Objective of pull request:

Pull request checklist

Your PR fulfills the following requirements:

  • Issue created that explains the change and why it's needed
  • Tests are part of the PR (for bug fixes / features)
  • Docs reviewed and added / updated if needed (for bug fixes / features)
  • PR conforms to Coding Conventions
  • PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • Lint (pyb) passes locally
  • Build tests (pyb -E unit) or (python -m unittest) passes locally

Pull request type

Please check your PR type:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes
  • Other (please describe):

What is the current behavior?

  • There is no support for sigma delta neuron.

What is the new behavior?

  • Sigma Delta neuron with Unit and ReLU activation is supported for both floating and fixed point.

Does this introduce a breaking change?

  • Yes
  • No

Supplemental information

@bamsumit
sigma delta process implemented
3747b8d 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
sigma delta refactoring
68f2973 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
delta unit fixes
769b808 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit
Linting Fixes
3a6dc35 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit self-assigned this Feb 15, 2022
@bamsumit bamsumit added the 1-feature New feature request label Feb 15, 2022
@bamsumit bamsumit linked an issue Feb 15, 2022 that may be closed by this pull request
Sigma Delta Neuron support #179
Closed
6 tasks
@bamsumit bamsumit added the 0-needs-review For all new issues label Feb 15, 2022
srrisbud
srrisbud requested changes Feb 15, 2022
View reviewed changes
@bamsumit bamsumit requested a review from srrisbud February 16, 2022 04:38
@mgkwill mgkwill self-requested a review February 23, 2022 17:35
@bamsumit bamsumit requested a review from tim-shea February 23, 2022 18:21
mgkwill
mgkwill approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor
@mgkwill mgkwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me.

There are a few optimizations available to you. See comments.

@bamsumit
Refactoring as Marcus suggested and minor typo fixes.
8e52247 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
tim-shea
tim-shea reviewed Feb 24, 2022
View reviewed changes
tim-shea
tim-shea reviewed Feb 24, 2022
View reviewed changes
tim-shea
tim-shea reviewed Feb 24, 2022
View reviewed changes
@bamsumit
added missing parameters in docstring.
337ed6b 
Signed-off-by: bamsumit <bam_sumit@hotmail.com>
@bamsumit bamsumit merged commit 72f31d4 into lava-nc:main Feb 24, 2022
@bamsumit bamsumit deleted the sigma_delta branch February 24, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-shea tim-shea tim-shea left review comments

@mgkwill mgkwill mgkwill approved these changes

@srrisbud srrisbud srrisbud approved these changes

@GaboFGuerra GaboFGuerra Awaiting requested review from GaboFGuerra

@mathisrichter mathisrichter Awaiting requested review from mathisrichter

Assignees

@bamsumit bamsumit

Labels
0-needs-review For all new issues 1-feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sigma Delta Neuron support
4 participants
@bamsumit @mgkwill @tim-shea @srrisbud
0