fix: improve PHPDoc for find method of QueryBuilder to support FETCH_ASSOC #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
322acce
to
b730e7b
Compare
szepeviktor
reviewed
Oct 24, 2024
b730e7b
to
0b1a17e
Compare
|
Thank you! It was mixed before actually 😅 And was recently changed to |
canvural
pushed a commit
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PHPDoc for the find() method declares the return type as object|null.
This likely stems from Laravel’s default fetchMode for the Database\Connection property being set to
PDO::FETCH_OBJ.However, when users customize theConnectionto usePDO::FETCH_ASSOC, this can result in numerous errors, as the return type differs.My attempt to override Larastan’s stub with a custom file was unsuccessful because PHPStan does not support overriding stub files.
This limitation highlights the need for a more flexible solution to accommodate different fetch modes without causing type-related errors.