8000 docs:clarify instructions on where to run maturin develop by HaochengLIU · Pull Request #3767 · lancedb/lance · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs:clarify instructions on where to run maturin develop #3767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2025
Merged

docs:clarify instructions on where to run maturin develop #3767

merged 1 commit into from
May 1, 2025

Conversation

HaochengLIU
Copy link
Contributor
@HaochengLIU HaochengLIU commented May 1, 2025 •
edited
Loading

maturin develop does not work at the top level directory, make it explicit in the guide.

➜  lance git:(improve-developer-guide-on-build) ✗ source .venv/bin/activate                  
((.venv) ) ➜  lance git:(improve-developer-guide-on-build) ✗ maturin develop          
💥 maturin failed
  Caused by: Failed to parse Cargo.toml at /Users/haochengliu/Documents/projects/lance/Cargo.toml
  Caused by: TOML parse error at line 1, column 1
  |
1 | [workspace]
  | ^
missing field `package`

@github-actions GitHub Actions
Copy link
github-actions bot commented May 1, 2025

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 1, 2025
@westonpace westonpace merged commit 8456b1a into lancedb:main May 1, 2025
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonpace westonpace westonpace approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaochengLIU @westonpace
0