8000 fix build constraint go1.8 by jro7 · Pull Request #993 · labstack/echo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix build constraint go1.8 #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2017
Merged

fix build constraint go1.8 #993

merged 2 commits into from
Aug 22, 2017

Conversation

jro7
Copy link
Contributor
@jro7 jro7 commented Aug 22, 2017

@codecov
Copy link
codecov bot commented Aug 22, 2017

Codecov Report

Merging #993 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   76.56%   76.39%   -0.18%     
==========================================
  Files          27       25       -2     
  Lines        2219     2207      -12     
==========================================
- Hits         1699     1686      -13     
  Misses        398      398              
- Partials      122      123       +1
Impacted Files Coverage Δ
util_go17.go 100% <ø> (ø) ⬆️
router.go 90.73% <0%> (-1.92%) ⬇️
echo.go 85.38% <0%> (-1%) ⬇️
util_go18.go
echo_go1.8.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d67651...bf53e94. Read the comment docs.

@codecov
Copy link
codecov bot commented Aug 22, 2017 •
edited
Loading

Codecov Report

Merging #993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #993   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files          27       27           
  Lines        2219     2219           
=======================================
  Hits         1699     1699           
  Misses        398      398           
  Partials      122      122
Impacted Files Coverage Δ
util_go17.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d67651...bf53e94. Read the comment docs.

@vishr vishr merged commit 6c54ff7 into labstack:master Aug 22, 2017
@vishr
Copy link
Member
vishr commented Aug 22, 2017

@jro7 thanks for your contribution 🎉

@vishr vishr mentioned this pull request Aug 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jro7 @vishr
0