864 - [Tick] The component is receving not recognize props causing a console warning #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the renderAxis function in the Chart component to convert tick props using the convertTickProps function. This ensures that tick rendering is consistent.
wesleydecezere
previously approved these changes
Oct 28, 2024
src/components/Chart/renderAxis.tsx
Outdated
| @@ -139,8 +144,7 @@ function getAxisProps( | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Talvez o problema da outra issue esteja aquitalvez o problema esteja aqui | |||
| const convertTickProps = (props: any): TickProps => ({ | |||
| export const convertTickProps = (props: any): TickProps => ({ | |||
There was a problem hiding this comment.
Since it is now being used by more than one file, it could be moved to a common file, like util.ts or model.ts
There was a problem hiding this comment.
Seems good. Just remember to follow the bold code patterns, not the PEC ones.
wagnerbsantos
previously approved these changes
Oct 29, 2024
GuilhermePrandi
previously approved these changes
Oct 29, 2024
zDudaHang
previously approved these changes
Oct 30, 2024
src/components/Chart/renderAxis.tsx
Outdated
| @@ -139,8 +144,7 @@ function getAxisProps( | |||
| } | |||
| } | |||
|
|
|||
| // TODO: Talvez o problema da outra issue esteja aquitalvez o problema esteja aqui | |||
| const convertTickProps = (props: any): TickProps => ({ | |||
| export const convertTickProps = (props: any): TickProps => ({ | |||
The base branch was changed.
carolinapsil
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #863
closes #864