8000 Add environment check for freestanding test : resolves #1186 by t-mat · Pull Request #1187 · lz4/lz4 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add environment check for freestanding test : resolves #1186 #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

Add environment check for freestanding test : resolves #1186 #1187

merged 1 commit into from
Dec 2, 2022

Conversation

t-mat
Copy link
Contributor
@t-mat t-mat commented Nov 9, 2022

Freestanding test is intended to run on only Linux x86_64 platform. Because it uses Linux x86_64 syscall directly to avoid any dependency to the standard library.

This changeset adds platform checking code to tests/Makefile to avoid unintended error in non-Linux x86_64 platforms.

This changeset resolves issue #1186

@t-mat
Add environment check for freestanding test
08f1483 
Freestanding test is intended to run on only Linux x86_64 platform.
Because it uses Linux x86_64 syscall directly to avoid any dependency to the standard library.

This changeset adds platform checking code to tests/Makefile to avoid unintended
error in non-Linux x86_64 platforms.

This changeset resolves issue lz4#1186
@tristan957
Copy link
Contributor

See my PR for Meson fix.

@t-mat
Copy link
Contributor Author
t-mat commented Nov 21, 2022

Note about plan of consequent PR:
As an adaptation of #1184, I'll add test-freestanding to the all of tests/Makefile.
Since we have macos platform, it'll be safeguard of same issue.

@Cyan4973 Cyan4973 merged commit d879e7f into lz4:dev Dec 2, 2022
t-mat added a commit to t-mat/lz4 that referenced this pull request Dec 3, 2022
@t-mat
Add "freestanding" to "all" and "test" of tests/Makefile
59578be 
Follow up of lz4#1184 and lz4#1187

Now `tests/Makefile` contains

- `freestanding` as a member of `all`.
- `test-freestanding` as a member of `test`.

Note that as for `all32` (`-m32`) builds, `test-freestanding` skips its actual test.
@t-mat t-mat mentioned this pull request Dec 3, 2022
Closed
t-mat added a commit to t-mat/lz4 that referenced this pull request Dec 3, 2022
@t-mat
Add "freestanding" to "all" and "test" of tests/Makefile
95d7c29 
Follow up of lz4#1184 and lz4#1187

Now `tests/Makefile` contains

- `freestanding` as a member of `all`.
- `test-freestanding` as a member of `test`.

Note that as for `all32` (`-m32`) builds, `test-freestanding` skips its actual test.
@moonfruit moonfruit mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t-mat @tristan957 @Cyan4973
0