[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings #16

Merged
merged 3 commits into from
Jan 13, 2017
Merged

Warnings #16

merged 3 commits into from
Jan 13, 2017

Conversation

luis-pereira
Copy link
Member

No description provided.

@luis-pereira
Adds common warning flags
c658a20 
These warnings are common to *probably* all compilers.
@luis-pereira
Adds gcc and clang specific warnings
9205566
palinek
palinek approved these changes Jan 9, 2017
View reviewed changes
Copy link
Contributor
@palinek palinek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@luis-pereira
Disables no-gnu-zero-variadic-macro-arguments for clang
674cad3 
It produces lots of no point noise with qCDebug(), qCWarning(), etc.
Found building lxqt-session.
@agaida agaida self-requested a review January 13, 2017 22:47
agaida
agaida approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member
@agaida agaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build the whole lxqt with this changes in amd64 and i386 - no problems, no regressions

@agaida agaida merged commit 4b511c1 into master Jan 13, 2017
@agaida agaida deleted the warnings branch January 13, 2017 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palinek palinek palinek approved these changes

@agaida agaida agaida approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luis-pereira @agaida @palinek