8000 Add `workflow_call` support in unittests workflow by JSabadin · Pull Request #93 · luxonis/datadreamer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add workflow_call support in unittests workflow #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2025
Merged

Add workflow_call support in unittests workflow #93

merged 5 commits into from
May 13, 2025

Conversation

JSabadin
Copy link
Contributor
@JSabadin JSabadin commented May 8, 2025

Purpose

PR Description:

  • Introduce workflow_call with ml_ref and datadreamer_ref inputs
  • Checkout datadreamer at specified ref when invoked externally
  • Install the target luxonis-ml version via ml_ref
  • Preserve existing behavior for PR-triggered runs
  • Enables BOM tests on external repos to validate integration in datadreamer

Specification

None / not applicable

Dependencies & Potential Impact

None / not applicable

Deployment Plan

None / not applicable

Testing & Validation

None / not applicable

@JSabadin JSabadin requested review from klemen1999 and sokovninn May 8, 2025 13:35
@github-actions GitHub Actions
Copy link
github-actions bot commented May 8, 2025 •
edited
Loading

Test Results

  6 files    6 suites   1h 24m 37s ⏱️
 87 tests  67 ✅  20 💤 0 ❌
522 runs  398 ✅ 124 💤 0 ❌

Results for commit daec212.

♻️ This comment has been updated with latest results.

klemen1999
klemen1999 reviewed May 8, 2025
View reviewed changes
@sokovninn
Copy link
Member

Do we also want to update the Tests workflow?

@klemen1999
Copy link
Contributor

Do we also want to update the Tests workflow?

With BOM we want to run the tests that use luxonis-ml. You know this repo tests the best @sokovninn so if you think that running unittests.yaml does not actually test luxonis-ml integration enough then we can run some other workflow as well.

@JSabadin JSabadin requested a review from klemen1999 May 13, 2025 10:53
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2007 1283 64% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: daec212 by action🐍

@JSabadin JSabadin merged commit 9baea6b into main May 13, 2025
16 of 17 checks passed
@JSabadin JSabadin deleted the feat/add-workflow_call-to-unittests branch May 13, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klemen1999 klemen1999 klemen1999 approved these changes

@sokovninn sokovninn Awaiting requested review from sokovninn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JSabadin @sokovninn @klemen1999
0