Add a special Wine version to represent the default Umu behavior #6183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowing it to install what version it likes. We can't seem to get the Wine executable, so I've had to work around that.
…NPATH' case more exactly.
…' in the install process as well.
Winetricks doesn't work with blank Umu, but at least there's a sensible error now.
…scripts. Fix hook up for various Wine commands, fixes for open-wine-terminal.
b96f4c5 to
ada45dd
Compare
…ork, we need a proper wine path. CabInstaller needs to be reworked to support Proton properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new fake Wine version
proton(presented as "Proton (Latest)") that has no Wine-path. Instead it executesumu-runwith noPROTONPATHset. Umu will download and use a version of Proton of its choice.This is not the same was "GE-Proton (Latest)"; that's a different version with @GloriousEggroll extra special sauce. I'm getting an older Proton version from Umu actually. This PR leaves "GE-Proton (Latest)" as it was.
This involves some bodges to redirect around the things that use the Wine-path so they use
umu-runin some way instead.Hope I got them all;Nope,CabInstallerdoesn't supportumu-runat all and it isn't going to work. That may break some installers (on "Proton (Latest)").It's all done with
ifstatements, so there's definitely a call for a cleanup pass on this once we've sorted out how all this works.