8000 Update gpu.py by blackPantherOS · Pull Request #6125 · lutris/lutris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update gpu.py #6125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update gpu.py #6125

wants to merge 1 commit into from

Conversation

blackPantherOS
Copy link
Contributor

Error handling resulting from unnecessary imports. Referer:
#5544 (comment)

@blackPantherOS
Update gpu.py
ec7fda0 
Error handling resulting from unnecessary imports. 
Referer:
lutris#5544 (comment)
@blackPantherOS
Copy link
Contributor Author

Not clear for me, what is ruff failing because:

$ruff check gpu.py 
All checks passed!

@eikeno
Copy link
Contributor
eikeno commented May 14, 2025

on https://github.com/lutris/lutris/actions/runs/15013338352/job/42185940806?pr=6125
you can see details after clicking on "Check Format" item in the list:

Run ruff format . --check
Would reformat: lutris/util/graphics/gpu.py
1 file would be reformatted, 296 files already formatted
Error: Process completed with exit code 1.

you can run make format to solve the problem (make sure you're in the correct env/venv if you're using one)
if using a venv, make sure to make dev before to install check tools (they need specific versions) via pip in the env.

hope this helps

@danieljohnson2
Copy link
Contributor

Hang on, this PR changes how we invoke vulkaninfo so that, if possible we would not use the env-vars VK_DRIVER_FILES and VK_ICD_FILENAMES.

I don't think that's right; that means we're not selecting the ICD for the specific GPU we want to probe.

I don't know what this is meant to do, but I do not like it.

@blackPantherOS
Copy link
Contributor Author

Hang on, this PR changes how we invoke vulkaninfo so that, if possible we would not use the env-vars VK_DRIVER_FILES and VK_ICD_FILENAMES.

I don't think that's right; that means we're not selecting the ICD for the specific GPU we want to probe.

I don't know what this is meant to do, but I do not like it.

I would clarify that we select the ICD only if it has not been selected yet. Since Vulkan is already initialized in our system, re-specifying the environment variables results in incorrect behavior when running Lutris. See the quoted thread on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackPantherOS @eikeno @danieljohnson2
2918
0