8000 Add moretype hints to lutris/game.py by eikeno · Pull Request #6074 · lutris/lutris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add moretype hints to lutris/game.py #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add moretype hints to lutris/game.py #6074

wants to merge 5 commits into from

Conversation

8000
eikeno
Copy link
Contributor
@eikeno eikeno commented Apr 24, 2025

... and a partially for a few other files, to pass checks.

Please let me know if this useful at all, or if there is no need to continue further this task gradually ?

@eikeno
Add moretype hints to lutris/game.py
5b72bf7 
... and a partially for a few other files, to pass checks.

Please let me know if this useful at all, or if there is no need to continue further this task gradually ?
@danieljohnson2
Copy link
Contributor

Watch out; you are using the 'sweet' syntax introduced in Python 3.10, like X | Y for a union. We target 3.8 which does not have that.

@eikeno
Copy link
Contributor Author
eikeno commented Apr 25, 2025

fixed.

Should I switch this to review-ready ?

I'm asking because I'm not sure how to continue:

  1. if this merged quickly, i can continue working on other files after syncing with master and create a branch per file
  2. if this is to be reviewed and potentially merged much later, please let me know as I'll have to continue on the same branch (for tests to work, as they are precious for this task) - in that case I'd keep the draft status to avoid confusion.

Thanks

@danieljohnson2
Copy link
Contributor

Well, I don't know what it is doing here at all if it isn't ready to review.

But don't expect a quick merge on this- I merge fixes, and this isn't a fix. @strycore might be willing to merge this, but I can't imagine he'd give it a lot of priority.

@eikeno eikeno marked this pull request as ready for review April 27, 2025 15:39
@eikeno
Copy link
Contributor Author
eikeno commented Apr 27, 2025 •
edited
Loading

Well, I don't know what it is doing here at all if it isn't ready to review.

that just what i was explaining in 1 and 2 (poorly,, it seems :-) and have feedback basically.

anyway, marked this ready, and I'll continue to update my branch, just hoping this be useful at some point.
I understand this is low pri, no problem with that, wasn't trying to force anything, just get info.

@Zebra2711
Copy link
Contributor

@eikeno please only merge lutris:master into your branch when it conflicts with the master branch. Also, squash your commits if needed to make it cleaner, instead of creating a bunch of nonsense commits merging lutris:master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eikeno @danieljohnson2 @Zebra2711
0