8000 Update go-diskfs to 1.5.0 by jqueuniet · Pull Request #184 · luthermonson/go-proxmox · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update go-diskfs to 1.5.0 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 8, 2025
Merged

Conversation

jqueuniet
Copy link
Contributor

go-diskfs added an abstraction layer over storage and os.File objects now cannot be used directly as they do not implement the backend.Storage interface.

Closes #183

Copy link
codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 28.41%. Comparing base (fdb95a1) to head (f36852c).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
virtual_machine.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   25.95%   28.41%   +2.45%     
==========================================
  Files          15       16       +1     
  Lines        1753     2323     +570     
==========================================
+ Hits          455      660     +205     
- Misses       1278     1614     +336     
- Partials       20       49      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jqueuniet
Copy link
Contributor Author

Note that this update raises Go version requirement from 1.20 to 1.22

@luthermonson luthermonson merged commit 481b57d into luthermonson:main Feb 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error in iso9660.Create from go-diskfs dependency
2 participants
0