10000 fix: Change `create_unknown_packages` default from `false` to `true` by wwared · Pull Request #424 · lurk-lab/lurk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Change create_unknown_packages default from false to true #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

fix: Change create_unknown_packages default from false to true #424

merged 1 commit into from
Feb 13, 2025

Conversation

wwared
Copy link
Contributor
@wwared wwared commented Feb 13, 2025

Changing the default behavior of the parser to create unknown packages for now. The issue is described in this comment: #422 (comment)

Once we have a better structure around interning symbols from other packages (including possibly unknown packages), this might be changed again in the future.

lurk-user> !(def .foo.bar 123) ;; this creates the unknown package `.foo`, by default it's empty
.foo.bar
lurk-user> !(in-package .foo)
.lurk.t
foo> bar
[1 iteration] => 123
foo>

@wwared wwared requested a review from porcuquine February 13, 2025 23:22
@wwared wwared merged commit 0f2f294 into main Feb 13, 2025
1 of 3 checks passed
@wwared wwared deleted the create-unknown-packages branch February 13, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@porcuquine porcuquine porcuquine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwared @porcuquine
0