feat: Use SP1 prover directly #413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the PrimeField32 bound where unnecessary
This impacts mainly long computations with a lot of sharding (see lair_shard_test) and large matrices, or large lair programs
After SP1 v4, the global lookup argument for cross-shard chip communication was drastically redesigned, which means our currently implementation is temporarily broken. See #437. The proper solution will require a proper design for sharded Lurk computation. This commit also removes all of the now-unnecessary dummy chips, since only single-shard computations can be proven right now.
winston-h-zhang
approved these changes
Mar 18, 2025
There was a problem hiding this comment.
@wwared There seem to be minimal deep changes other than removing sphinx stuff and using Arc. This looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR entirely removes all Sphinx dependencies and replaces them with their respective SP1 counterparts, using the latest version published to
crates.io.Because of performance-oriented changes in SP1 v4, the lookup argument for cross-shard communication was redesigned, and our current implementation now only works in a single shard temporarily. A workaround is possible, but was not implemented to minimize complexity (see #437). The impact is only for long computations, and those already had other underlying issues, that this PR does not aim to fix.
As a result to this, there might be a regression in our test runtimes or benchmarks, but everything else should still be mostly the same.
The plonky3 crates are using released versions, except for
p3-poseidon2, which is using a slightly patched branch in https://github.com/lurk-lab/p3/tree/sp1-v4