Create pdf for Santander registered boleto #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyboleto/bank/santander.py
Outdated
| self.instrucoes = kwargs.pop('instrucoes', []) | ||
| super(BoletoRegistradoSantander, self).__init__(**kwargs) | ||
|
|
||
| def nosso_numero_by_santander(self): |
There was a problem hiding this comment.
Que tal ser uma property? 🤔
renanivo
reviewed
May 30, 2017
pyboleto/bank/santander.py
Outdated
| def nosso_numero_by_santander(self): | ||
| """ On new Webservice for boleto, | ||
| santander can create their own | ||
| our_number with 13 and without dv |
There was a problem hiding this comment.
Não seria "nosso_numero" mesmo? Acho que não foi usado our_number em nenhum outro lugar.
There was a problem hiding this comment.
Eu estava usando our_numberem outro projeto e acabei me confundindo na hora de escrever essa parte. Vou arrumar.
RomuloOliveira
approved these changes
May 31, 2017
maurobaraldi-luizalabs
approved these changes
Jun 5, 2017
e7029f2 to
fc46338
Compare
renanivo
approved these changes
Jun 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.