8000 Release 0.23.0 by kevinstratford · Pull Request #352 · ludwig-cf/ludwig · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release 0.23.0 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 162 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
162 commits
Select commit Hold shift + click to select a range
2b058ee
add slurm and input file
Mar 31, 2023
440514c
Update README.md
Apr 11, 2023
9b577fb
Update README.md
Apr 11, 2023
86e9d51
Update README.md
Apr 11, 2023
dc62aea
add config
Jun 8, 2023
b2a947f
interchange plane,side,jc,kc, tested right
Jun 10, 2023
7a6d1ca
add kernel and copy model, the result is wrong now
Jun 10, 2023
477321a
modify 'copy model' function and the function is tested effective
Jun 12, 2023
c8b22c3
still can't get correct result, this commit is to save some possible …
Jun 13, 2023
e7fbb8c
the result of reprojection is correct now, ready to move on
Jun 15, 2023
263bd6d
parallelised interpolation, can run successfully but the result is wrong
Jun 19, 2023
03fe861
same as last commit, just clean some comments
Jun 21, 2023
ae773e9
modulised interpolation, but the result remains the same
Jun 22, 2023
7410ce0
fixed some bugs of the formoer version, the result is tested correct …
Jun 23, 2023
de757f4
the result is correct now, those failed tests are expected to fail, s…
Jun 30, 2023
577ad99
reduced the number of kernel lanuchs by parallelising the loop of pla…
Jul 2, 2023
dab82d6
resize the recv_buffer and modify the index, the result is correct now
Jul 7, 2023
068996b
changed part of the cuda to tdp, it works. This commit is to reserve …
Jul 13, 2023
0ee36d5
finish applying tdp on itepolation, there is reprojection to go
Jul 13, 2023
fd24e77
add recv_buff in the lb struct, and add allocation and deallocation o…
Jul 15, 2023
464f60c
used tdp in reprojection
Jul 15, 2023
23178b5
small modifications, can ignore this commit, the result doesn't change
Jul 19, 2023
4899371
move the calculation of displacment and nprop into kernel, and calsul…
Jul 20, 2023
271821b
change to merge
Jul 20, 2023
7418e5a
finish merge
Jul 20, 2023
0de830d
modified the code to adapt the new code which deleted buffer_duy in t…
Jul 21, 2023
2588adf
former verion has a small bug, fixed it
Aug 5, 2023
2be1cf3
delete some comments
Aug 14, 2023
2db19dd
Merge remote-tracking branch 'upstream/master'
Aug 14, 2023
1651980
add initial implementation for gpu aware mpi communication of halos
Jul 22, 2024
f10b883
Merge branch 'develop' into gpu_aware_mpi
Jul 25, 2024
1c502c3
Add i/o aggregator check
Jul 26, 2024
3d8c9c6
use tdp calls to launch kernels
Jul 29, 2024
4e3e8b6
use reduced halos for allocating send and receive buffers on the device
Jul 30, 2024
bf66890
update halo free function to gree device pointers
alexei-borissov Aug 1, 2024
f07483d
Update issue templates
ludwig-cf Aug 8, 2024
b8ed6ef
Merge pull request #320 from ludwig-cf/feature-issue-templates
kevinstratford Aug 12, 2024
9255199
Merge pull request #318 from ludwig-cf/fix-issue-277
kevinstratford Aug 12, 2024
4a026eb
debugging
alexei-borissov Aug 13, 2024
f854feb
remove print statements
alexei-borissov Aug 14, 2024
5d4af34
add model copies, make sure we're waiting on the target rather than t…
alexei-borissov Aug 26, 2024
3837d6a
remove debugging print statements
alexei-borissov Aug 26, 2024
4d3cbcf
don't double count halo sizes
alexei-borissov Sep 6, 2024
0d3c218
Relax cell list minimum constraint for ellipsoids
kevinstratford Oct 1, 2024
90dda90
Check all tdp return values
kevinstratford Oct 4, 2024
b586682
Format/spelling updates
kevinstratford Oct 4, 2024
291b2c4
Merge pull request #326 from ludwig-cf/fix-issue-325
kevinstratford Oct 4, 2024
e1ae328
Add missing target
kevinstratford Oct 4, 2024
3d5f18e
Merge pull request #327 from ludwig-cf/fix-issue-322
kevinstratford Oct 4, 2024
a6d35d5
add nvtx timers
alexei-borissov Oct 8, 2024
a702812
initial graph implementation
alexei-borissov Oct 10, 2024
63b4aea
debugging graph api implementation
alexei-borissov Oct 11, 2024
517a3f0
Merge pull request #324 from ludwig-cf/feature-323-cell-list
kevinstratford Oct 21, 2024
144bcff
Add dynamic update for 2d disks
kevinstratford Oct 23, 2024
d46434c
Format, spelling
kevinstratford Oct 23, 2024
9a3bf83
Merge pull request #329 from ludwig-cf/fix-issue-328
kevinstratford Oct 24, 2024
1ed9005
Add separate disk squirmer section
kevinstratford Nov 5, 2024
a73578c
Merge pull request #331 from ludwig-cf/fix-issue-328
kevinstratford Nov 15, 2024
4da9164
Work on stub errors return
kevinstratford Nov 15, 2024
e1e277b
Improve error handling
kevinstratford Nov 24, 2024
6e38078
Format/spelling
kevinstratford Nov 25, 2024
7c1f20e 8000
Fix typo in assertion
kevinstratford Nov 25, 2024
f71946d
Replace trivial switch statement
kevinstratford Nov 25, 2024
bb693cf
Remove repeat declaration
kevinstratford Nov 25, 2024
dafc406
Merge pull request #333 from ludwig-cf/feature-209-mpi-stub-tests
kevinstratford Nov 25, 2024
8964a85
Remove repeated update of swinning directiion
kevinstratford Nov 27, 2024
2bf3622
..and remove unused variable
kevinstratford Nov 27, 2024
360ac42
Merge pull request #334 from ludwig-cf/fix-issue-330
kevinstratford Nov 27, 2024
58432e0
debugging graph api implmentation
alexei-borissov Dec 2, 2024
59a53bc
Makefile should return a failure on failure
kevinstratford Dec 6, 2024
95c9952
Update test result for issue 330
kevinstratford Dec 6, 2024
36cc95d
Update Makfile
kevinstratford Dec 6, 2024
55e619a
Merge pull request #336 from ludwig-cf/fix-issue-330
kevinstratford Dec 6, 2024
8612596
Repair GPU tests
Dec 6, 2024
46b5504
Spelling
kevinstratford Dec 6, 2024
f525628
Merge pull request #337 from ludwig-cf/fix-issue-335
kevinstratford Dec 6, 2024
f8e7529
debugging
alexei-borissov Dec 19, 2024
18c0639
Merge branch 'gpu_aware_mpi' into gpu_aware_mpi_graph_debug
alexei-borissov Dec 19, 2024
9523734
remove graph implementation
alexei-borissov Dec 19, 2024
76e7114
In progress
Dec 19, 2024
a742f1b
Merge branch 'develop' into gpu_aware_mpi
alexei-borissov Dec 19, 2024
f3eb55d
reintroduce copy of cs to device
alexei-borissov Dec 19, 2024
2f7b7a1
Code quality updates
kevinstratford Dec 24, 2024
882f9d3
CodeQL v3
kevinstratford Dec 25, 2024
15333d7
CodeQL v3
kevinstratford Dec 25, 2024
c059fde
d2q9 / mpi test
kevinstratford Dec 25, 2024
fe81bec
d3q15 / mpi test
kevinstratford Dec 25, 2024
155156d
d3q15 / mpi test
kevinstratford Dec 25, 2024
742cbd1
d3q15 / mpi test
kevinstratford Dec 25, 2024
131341c
d3q15 / mpi test
kevinstratford Dec 25, 2024
e831fb2
move mpi tests to openmpi
kevinstratford Dec 25, 2024
d57ae1a
Add read report
kevinstratford Dec 25, 2024
60b0b4e
Switch off target
kevinstratford Dec 27, 2024
f2a4b35
Remove comment
kevinstratford Dec 27, 2024
49ec45f
Merge pull request #339 from ludwig-cf/fix-issue-338
kevinstratford Dec 27, 2024
da8f8b3
Remove constraint on ndim for binary collision
Dec 27, 2024
59a6fbd
Updated LE to allow GPU
Dec 27, 2024
f5cbaff
Minor corrections
kevinstratford Dec 27, 2024
01e6dbf
Replace with descriptive comments
kevinstratford Dec 27, 2024
64e3fb5
Merge branch 'develop' into fix-issue-321
kevinstratford Dec 27, 2024
6e5d5d0
Avoid semi-colon in code-like comment
kevinstratford Dec 27, 2024
9590511
Merge pull request #340 from ludwig-cf/fix-issue-321
kevinstratford Dec 27, 2024
97b8f25
check whether we're using the target halo implementation
alexei-borissov Jan 6, 2025
f3feb80
remove nvtx
alexei-borissov Jan 6, 2025
8000
87d1507
remove excess calls to halo_post and wait
alexei-borissov Jan 6, 2025
53e19fc
tidy
alexei-borissov Jan 6, 2025
6650806
remove unused variable
alexei-borissov Jan 6, 2025
c4f0d5c
Merge branch 'develop' into gpu_aware_mpi
alexei-borissov Jan 9, 2025
6ddf756
comment copymodeltodevice
alexei-borissov Jan 9, 2025
f67b38c
add halo device model initialise and free functions
alexei-borissov Jan 13, 2025
dfe316c
remove commented code
alexei-borissov Jan 13, 2025
79ac9d7
Merge branch 'gpu_aware_mpi' into gpu_aware_mpi_graph_debug
alexei-borissov Jan 13, 2025
3863565
add function for initialising halo model on device
alexei-borissov Jan 17, 2025
a123254
reintroduce calls to graph launch that were removed when merging main…
alexei-borissov Jan 19, 2025
dfb45c6
remove debugging print statements
alexei-borissov Jan 20, 2025
b87282f
deactivate graph implementation
alexei-borissov Jan 20, 2025
f300c01
remove lb_halo_swap
alexei-borissov Jan 20, 2025
808cabc
remove commented code
alexei-borissov Jan 22, 2025
a10ae9b
set halo target to zero
alexei-borissov Jan 22, 2025
7bd91bb
don't allocate zero sized arrays
alexei-borissov Jan 22, 2025
5bda6d0
move initialise device functions inside check for ndevice non-zero
alexei-borissov Jan 22, 2025
cb537a3
add tdpassert
alexei-borissov Jan 22, 2025
2657175
don't construct graph nodes when request size is zero
alexei-borissov Jan 22, 2025
a28d69b
correct send recv counts
alexei-borissov Jan 22, 2025
9c911d4
use halo->count when deciding to skip building nodes which would have…
alexei-borissov Jan 23, 2025
e0b7de9
copy send and receive buffers from device to host if not using gpu aw…
alexei-borissov Jan 23, 2025
7d1cf9e
don't fiddle with haloscheme
alexei-borissov Jan 23, 2025
2cd14d2
remove debugging print statement
alexei-borissov Jan 23, 2025
ac457af
promote scount to size_t
alexei-borissov Jan 23, 2025
c544140
promote rcount to size_t
alexei-borissov Jan 23, 2025
14bab2f
Additional functions to estimate links required
kevinstratford Jan 28, 2025
cffeedf
New state i/o to buffer
kevinstratford Jan 28, 2025
61cd0a2
Additional test
kevinstratford Jan 28, 2025
36078e2
Add io version
kevinstratford Jan 28, 2025
5380b93
Avoid dubious cast
kevinstratford Jan 28, 2025
e6696b9
Avoid checks on floating point equality
kevinstratford Jan 28, 2025
3e3a736
Merge pull request #344 from ludwig-cf/feature-317
kevinstratford Jan 28, 2025
0754b79
Fix to allow non-uniform wetting
kevinstratford Jan 28, 2025
b3c2565
Merge pull request #345 from ludwig-cf/fix-issue-343
kevinstratford Jan 29, 2025
8c6c486
Add have_gpu_aware_mpi_()
kevinstratford Jan 29, 2025
05ac53b
Replace macros by have_gpu_aware_mpi_ function
kevinstratford Jan 29, 2025
a255fcf
Merge pull request #346 from ludwig-cf/fix-issue-311
kevinstratford Jan 30, 2025
4cc6402
rationalise lb halo options and tests
kevinstratford Feb 9, 2025
ddc10e4
Merge branch 'develop' into feature-311-gpu-aware-mpi
kevinstratford Feb 9, 2025
4847c05
Merge development
kevinstratford Feb 9, 2025
77cd7a3
Correct logix
kevinstratford Feb 9, 2025
43fdce0
Correction to position of ()
kevinstratford Feb 16, 2025
4f08549
Move to static inline
kevinstratford Feb 16, 2025
13dd0fd
Remove old implementation
kevinstratford Feb 16, 2025
a6d8dce
Replace ndist function
kevinstratford Feb 16, 2025
f7258a7
Update i/o freq keys and i/o error messages
kevinstratford Feb 17, 2025
146c94a
Minor format updates
kevinstratford Feb 17, 2025
26d8d7e
Avoid mod 0 undefined behaviour
kevinstratford Feb 17, 2025
a39b85d
Correction to return value
kevinstratford Feb 17, 2025
6cccdba
Merge pull request #351 from ludwig-cf/fix-issue-350
kevinstratford Feb 18, 2025
6f9a916
Merge branch 'develop' into feature-311-gpu-aware-mpi
Feb 21, 2025
0b3448c
Correct comment
Feb 21, 2025
0486c27
General configuration for GPU MPI
Feb 21, 2025
16c0622
Remove old halo code
Feb 21, 2025
46b0e99
Repair GPU version
Feb 21, 2025
8ed63e9
Merge pull request #347 from ludwig-cf/feature-311-gpu-aware-mpi
kevinstratford Feb 21, 2025
05c2d25
Release 0.23.0
kevinstratford Feb 27, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: bug
assignees: ''

---

**Please provide a clear and concise description of the problem.**
What is the problem?

**How do we reproduce the problem?**
Consider including:
1. Details of the platform/compiler, i.e., your `config.mk` file
2. The relevant `input` file and run time environment (MPI?)
3. Details of any error messages

**Expected behavior**
What do you expected to happen?

**Any other relevant details**
18 changes: 18 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: enhancement
assignees: ''

---

**Summary**
Please summarise what is missing, or what needs to be added.

**Describe the solution you'd like**
Please provide a clear and concise description of what you want to happen.


**What's required?**
Summarise the steps which may be required to implement the feature.
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/general-questions.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
name: General questions
about: Please ask ...
title: ''
labels: ''
assignees: ''

---


4 changes: 2 additions & 2 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@v3
with:
languages: ${{ matrix.language }}
queries: +security-and-quality
Expand All @@ -53,4 +53,4 @@ jobs:
make

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@v3
4 changes: 4 additions & 0 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ jobs:
uses: actions/checkout@v4
- name: Set up MPI
uses: mpi4py/setup-mpi@v1
with:
mpi: openmpi
- run: mpicc --version
- run: cp config/github-mpicc.mk config.mk
- run: make -j 2
Expand All @@ -118,6 +120,8 @@ jobs:
uses: actions/checkout@v4
- name: Set up MPI
uses: mpi4py/setup-mpi@v1
with:
mpi: openmpi
- run: mpicc --version
- run: cp config/github-mpicc.mk config.mk
- run: sed -i "s/D2Q9/D3Q15/" config.mk
Expand Down
18 changes: 18 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@

### Changes

version 0.23.0

- Action required. Changes to input file keys related to frequency of i/o.
Please see https://ludwig.epcc.ed.ac.uk/outputs/fluid.html
for a list of new keys to specify output frequenxy. These
provide a more flexible and consistent framework for
specifying output for all lattice quantities.
Old forms will be trapped at run time with a request to
update your input file. [Issue 350]

- A number of GPU features have been implemented including the
lattice distribution halo swap and the Lees Edwards plane
transformation. [Issues 311, 316, 343]

- Bug fix [Issue 342] Colloid wettability (free energy parameters
were being erroneously replaced in the gradient calculation.
Colloid wetting factors are now taken into account correctly.

version 0.22.0

- Removal of original "ansi" I/O (Issue 284).
Expand Down
3 changes: 1 addition & 2 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ coverage:
status:
project:
default:
target: 33%
threshold: 2%
informational: true
patch:
default:
informational: true
1 change: 1 addition & 0 deletions config/unix-nvcc-default.mk
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

BUILD = parallel
MODEL = -D_D3Q19_
TARGET = nvcc

CC = nvcc
CFLAGS = -ccbin=mpicc -O2 -DADDR_SOA -arch=sm_61 -x cu -dc
Expand Down
21 changes: 21 additions & 0 deletions mpi_s/mpi.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ typedef MPI_Handle MPI_Info;
typedef struct {
int MPI_SOURCE;
int MPI_TAG;
int MPI_ERROR;
} MPI_Status;

#define MPI_STATUS_IGNORE ((MPI_Status *) 0)
Expand All @@ -57,8 +58,23 @@ typedef intmax_t MPI_Offset;

enum return_codes {
MPI_SUCCESS = 0, /* Success */
MPI_ERR_ACCESS, /* Permission denied */
MPI_ERR_AMODE, /* Invalid mode argument */
MPI_ERR_ARG, /* Invalid argument of other kind */
MPI_ERR_BUFFER, /* Invalid buffer pointer argument */
MPI_ERR_COMM, /* Invalid communicator argument */
MPI_ERR_COUNT, /* Invalid count argument */
MPI_ERR_DATATYPE, /* Invalid datatype */
MPI_ERR_INFO, /* Invalid info argument */
MPI_ERR_ERRHANDLER, /* Invalid errhandler handle */
MPI_ERR_INTERN, /* Internal (implementation) error */
MPI_ERR_IO, /* Other i/o error */
MPI_ERR_FILE, /* Bad file handle */
MPI_ERR_NO_SUCH_FILE, /* File does not exist */
MPI_ERR_OP, /* Invalid operation argument */
MPI_ERR_RANK, /* Invalid rank argument */
MPI_ERR_ROOT, /* Invalid root argument */
MPI_ERR_TAG, /* Invalid tag */
MPI_ERR_LASTCODE /* Must be last */
};

Expand All @@ -70,8 +86,11 @@ enum return_codes {
#define MPI_BOTTOM 0x0000
#define MPI_UNDEFINED -999


/* Error-handling specifiers */

#define MPI_MAX_ERROR_STRING 256

enum error_specifiers {MPI_ERRORS_ARE_FATAL, MPI_ERRORS_RETURN};

enum elementary_datatypes {MPI_CHAR = -11,
Expand Down Expand Up @@ -249,6 +268,8 @@ int MPI_Cart_sub(MPI_Comm comm, int * remain_dims, MPI_Comm * new_comm);
/* Bindings for environmental inquiry */

int MPI_Errhandler_set(MPI_Comm comm, MPI_Errhandler errhandler);
int MPI_Error_string(int ierr, char * str, int * lenresult);
int MPI_Error_class(int ierrcode, int * ierrclass);

double MPI_Wtime(void);
double MPI_Wtick(void);
Expand Down
Loading
0