[BUGFIX] Guard against UnicodeEncodeError when saving validation results in Google Colab environment #3875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uate/unicode_encode_error_ascii_code-2024_01_07-24
…uate/unicode_encode_error_ascii_code-2024_01_07-24
…uate/unicode_encode_error_ascii_code-2024_01_07-24
… otherwise, "UnicodeEncodeError" may be raised (happens in Google Colab account).
arnavgarg1
approved these changes
Jan 10, 2024
|
It's probably worth specifying the encoding everywhere we are writing files to disk! |
vijayi1
pushed a commit
to vijayi1/ludwig
that referenced
this pull request
Jan 23, 2024
…lts in Google Colab environment (ludwig-ai#3875)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request
3027
is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
If the textual data in the validation dataset contains non-ASCII characters, saving the results to storage may encounter errors, such as:
The fix consists of defensively converting the contents to the
UTF-8format.Remark
This error was not observed in isolated GPU environments such as while using EC2 outside of Colab, but this change assures stable behavior in all environments.