OnnxExporter #3761
OnnxExporter #3761
Conversation
Unit Test Results 6 files ±0 6 suites ±0 27m 29s ⏱️ - 2m 54s For more details on these failures, see this check. Results for commit 180cad7. ± Comparison against base commit dc3ec73. ♻️ This comment has been updated with latest results. |
|
Hi @skanjila, it looks like there's a couple of pre-commit issues to resolve: https://results.pre-commit.ci/run/github/163346054/1699499452.zgxnE5vuTJujO_3rx1xLkQ |
| return self.model({"image_path": x})< 8000 /span> | ||
|
|
||
|
|
||
| class BaseModelExporter(ABC): |
There was a problem hiding this comment.
Could we add docstrings to these new classes?
ludwig/model_export/onnx_exporter.py
Outdated
| from ludwig.model_export.base_model_exporter import LudwigTorchWrapper | ||
|
|
||
|
|
||
| class OnnxExporter(ABC): |
There was a problem hiding this comment.
Did you mean to inherit from BaseModelExporter?
There was a problem hiding this comment.
yes I did, just forgot to put that in so added this just now
Code Pull Requests
Please provide the following:
Documentation Pull Requests
Note that the documentation HTML files are in
docs/while the Markdown sources are inmkdocs/docs.If you are proposing a modification to the documentation you should change only the Markdown files.
api.mdis automatically generated from the docstrings in the code, so if you want to change something in that file, first modifyludwig/api.pydocstring, then runmkdocs/code_docs_autogen.py, which will createmkdocs/docs/api.md.