fixed typo in EfficientNet's model variant from v2_ to v2_s #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinxzhao
approved these changes
Sep 18, 2023
|
Hi @saad-palapa, thanks for the change. Looks like this is indeed an error, with v2_s as the correct variant name. |
Unit Test Results 4 files ±0 4 suites ±0 36m 15s ⏱️ + 6m 17s Results for commit 1f0aa00. ± Comparison against base commit 42723e3. This pull request skips 2 tests. |
1f0aa00 to
2032f0b
Compare
Infernaught
pushed a commit
to Infernaught/nightlyfix
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Pull Requests
Fixed a typo in
EfficientNet's model variant that broke trainingDocumentation Pull Requests
Note that the documentation HTML files are in
docs/while the Markdown sources are inmkdocs/docs.If you are proposing a modification to the documentation you should change only the Markdown files.
api.mdis automatically generated from the docstrings in the code, so if you want to change something in that file, first modifyludwig/api.pydocstring, then runmkdocs/code_docs_autogen.py, which will createmkdocs/docs/api.md.