8000 Set default local backend when doing quantization by Infernaught · Pull Request #3518 · ludwig-ai/ludwig · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Set default local backend when doing quantization #3518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Set default local backend when doing quantization #3518

wants to merge 1 commit into from

Conversation

Infernaught
Copy link
Contributor

Previous: set default backend to ray if ray was installed

Now: set default backend to local if quantization is being used (quantization is set in the config)

@Infernaught Infernaught self-assigned this Aug 10, 2023
@github-actions
Copy link

Unit Test Results

  6 files  ±0    6 suites  ±0   1h 1m 45s ⏱️ - 3m 28s
34 tests ±0  27 ✔️  - 2    7 💤 +2  0 ❌ ±0 
88 runs  ±0  64 ✔️  - 8  24 💤 +8  0 ❌ ±0 

Results for commit 1c62435. ± Comparison against base commit 92d07f6.

This pull request skips 2 tests. 
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[ames_housing.gbm.yaml]
tests.regression_tests.benchmark.test_model_performance ‑ test_performance[mercedes_benz_greener.gbm.yaml]

arnavgarg1
arnavgarg1 requested changes Aug 11, 2023
View reviewed changes
Copy link
Contributor
@arnavgarg1 arnavgarg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we want to move this down into a config validation check since this issue only happens when Ray is installed on the system, in which case we default to Ray backend instead of Local backend.

The config validation should ensure that when quantisation is set, backend is not empty + that it must be set explicitly to local (double check that the second part of this doesn't already exist).

@arnavgarg1
Copy link
Contributor

Closing in favor of #3524

@arnavgarg1 arnavgarg1 closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnavgarg1 arnavgarg1 arnavgarg1 requested changes

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao is a code owner

Assignees

@Infernaught Infernaught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Infernaught @arnavgarg1
0