Implement password submodule for @lute/crypto.
#319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements a new password submodule for @lute/crypto, adding secure hashing and verification functions using libsodium. Key changes include:
- New functions (lua_pwhash and lua_pwhash_verify) and a helper (extractData) for processing string and buffer inputs.
- Updates to header files and build configuration to integrate libsodium.
- An example demonstrating the new password API usage.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lute/crypto/src/crypto.cpp | Adds password-related functions and a helper to extract binary data, with a potential bug in argument index usage. |
| lute/crypto/include/lute/crypto.h | Declares new constants and functions for password hashing. |
| lute/crypto/CMakeLists.txt | Links against the libsodium library. |
| extern/libsodium.tune | Configures the libsodium dependency. |
| examples/pwhash.luau | Provides usage examples of the new password API. |
| CMakeLists.txt | Includes libsodium integration for the project. |
| CMakeBuild/libsodium.cmake | Adds the CMake build integration for libsodium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #161, implements a password submodule of
@lute/cryptowithhashandverifyfunctions that allow you to appropriately hash and verify passwords securely. The underlying implementation leverages libsodium because boringssl does not feature any appropriate key derivation functions. We will continue to prefer boringssl cryptography to libsodium for digest and other additional functionality for the library.