Make Lute a single-folder VS Code workspace #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatxe
approved these changes
May 13, 2025
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
VS Code has varying levels of settings overrides. The most basic is user settings, then workspace settings, followed by project folder settings. Currently, we store project settings in `.vscode/settings.json`, which means that we can't add the `.vscode` directory to `.gitignore`. This PR creates a [multi-root workspace](https://code.visualstudio.com/docs/editing/workspaces/multi-root-workspaces) containing only the root folder of this repository, which allows us to store these settings in `lute.code-workspace` instead. Now, `.vscode` is added to `.gitignore` and can be used for defining local-only launch and task configurations. This also means that we can add workspace-level launch and task configurations (which would run luthier) that come packaged with this repository by default in `lute.code-workspace`. As long as the repository is opened in VS Code as a workspace, this should behave the same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS Code has varying levels of settings overrides. The most basic is user settings, then workspace settings, followed by project folder settings. Currently, we store project settings in
.vscode/settings.json, which means that we can't add the.vscodedirectory to.gitignore.This PR creates a multi-root workspace containing only the root folder of this repository, which allows us to store these settings in
lute.code-workspaceinstead. Now,.vscodeis added to.gitignoreand can be used for defining local-only launch and task configurations.This also means that we can add workspace-level launch and task configurations (which would run luthier) that come packaged with this repository by default in
lute.code-workspace.As long as the repository is opened in VS Code as a workspace, this should behave the same as before.