8000 Avoid allocation on net.serve with single chunk request body by Nicell · Pull Request #221 · luau-lang/lute · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid allocation on net.serve with single chunk request body #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
8000
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Avoid allocation on net.serve with single chunk request body #221

merged 2 commits into from
Apr 28, 2025

Conversation

Nicell
Copy link
Collaborator
@Nicell Nicell commented Apr 28, 2025

In #213 a buffer was added to ensure we get every chunk passed on. This also made single-chunk requests slower due to an unnecessary buffer allocation. We can make this faster by directly passing the first chunk when it's also the last chunk and avoid maintaining a separate buffer.

@aatxe aatxe merged commit 5c470d0 into luau-lang:primary Apr 28, 2025
6 checks passed
green-real pushed a commit to green-real/lute that referenced this pull request May 19, 2025
@Nicell
Avoid allocation on net.serve with single chunk request body (luau-la…
f85450e 
…ng#221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatxe aatxe aatxe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nicell @aatxe
0