-
Notifications
You must be signed in to change notification settings - Fork 16
Introduce @lute/time runtime library #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8000
Jump to bottom
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatxe
requested changes
Apr 28, 2025
aatxe
reviewed
May 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks pretty good, just needs a little more cleanup.
aatxe
approved these changes
May 1, 2025
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
Closes issue luau-lang#75 by introducing a time library. Includes a `time.now()` function, which uses libuv's cross-platform `clock_gettime` function for instants with nanosecond precision. Since libuv's return result is `sec` + `nsec`, we cast both into doubles and then divide down. `time` isn't available as a namespace name due to conflicts in other include statements, so the namespace is `libtime`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #75 by introducing a time library.
Includes a
time.now()
function, which uses libuv's cross-platformclock_gettime
function for instants with nanosecond precision. Since libuv's return result issec
+nsec
, we cast both into doubles and then divide down.time
isn't available as a namespace name due to conflicts in other include statements, so the namespace islibtime
.