8000 CST: Handle repeat, break and continue by JohnnyMorganz · Pull Request #210 · luau-lang/lute · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

CST: Handle repeat, break and continue #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2025
Merged

CST: Handle repeat, break and continue #210

merged 2 commits into from
Apr 26, 2025

Conversation

JohnnyMorganz
Copy link
Collaborator

This PR adds support for serializing all the the repeat stmt node, as well as break and continue last stmt

For break and continue, it is fairly simple - we serialize the tokens directly.

For repeat, we serialize the repeat and until tokens using the CST data, alongside the condition and body.

Base automatically changed from johnny/cst/while to primary April 25, 2025 23:48
@aatxe
Copy link
Collaborator
aatxe commented Apr 25, 2025

This needs to be rebased still though.

@JohnnyMorganz JohnnyMorganz force-pushed the johnny/cst/repeat-break-continue branch from dfea5c5 to db036c4 Compare April 26, 2025 08:50
@JohnnyMorganz JohnnyMorganz enabled auto-merge (squash) April 26, 2025 08:50
@JohnnyMorganz JohnnyMorganz merged commit 3510109 into primary Apr 26, 2025
6 checks passed
@JohnnyMorganz JohnnyMorganz deleted the johnny/cst/repeat-break-continue branch April 26, 2025 08:54
green-real pushed a commit to green-real/lute that referenced this pull request May 19, 2025
@JohnnyMorganz
CST: Handle repeat, break and continue (luau-lang#210)
deb32a3 
This PR adds support for serializing all the the repeat stmt node, as
well as `break` and `continue` last stmt

For break and continue, it is fairly simple - we serialize the tokens
directly.

For repeat, we serialize the `repeat` and `until` tokens using the CST
data, alongside the condition and body.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatxe aatxe aatxe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnnyMorganz @aatxe
0