Add HTTP Server to net
#105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a2379a
8000
to
8404c8b
Compare
aatxe
requested changes
Mar 19, 2025
|
We have learned that git-subrepo does not play nicely with submodules and uWebSockets, naturally, uses submodules and Make. I think the right way forward here is to build a little bit of dependency management into |
aatxe
added a commit
that referenced
this pull request
Mar 19, 2025
We've already hit a wall with git-subrepo in #105 because subrepos interact awfully with submodules. All of this is miserable, and I think we're going to go the way that every mid-sized C++ project with dependencies must go to stay sane: embracing their own bespoke tool. As such, I've replaced the check-in for every dependency here with a `foo.tune` file in `extern` that describes the remote source and the tag that we would like to check out, and `luthier` now has the ability to fetch dependencies. It will do this as part of a `configure` step, but you can also invoke it directly with the `fetch` subcommand.
aatxe
reviewed
Mar 21, 2025
aatxe
reviewed
Mar 21, 2025
aatxe
approved these changes
Mar 21, 2025
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
We've already hit a wall with git-subrepo in luau-lang#105 because subrepos interact awfully with submodules. All of this is miserable, and I think we're going to go the way that every mid-sized C++ project with dependencies must go to stay sane: embracing their own bespoke tool. As such, I've replaced the check-in for every dependency here with a `foo.tune` file in `extern` that describes the remote source and the tag that we would like to check out, and `luthier` now has the ability to fetch dependencies. It will do this as part of a `configure` step, but you can also invoke it directly with the `fetch` subcommand.
green-real
pushed a commit
to green-real/lute
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an http server to
net. This server is backed by uWebSockets, a very fast, standards-compliant HTTP/WebSocket server that powers bun also. The API isn't fully thought through yet, but this is a start. Other things to think about include:The above things seem like they can be follow up PRs since we don't have a stable API. For now this is a basic API we can play around with and build off of.