-
Notifications
You must be signed in to change notification settings - Fork 35
Make ifupdown optional for udev users #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of servic 8000 e and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @mpatnode!
All very good points and, to be honest...
I think this is a very good direction and that we should get rid of all the requirements possible and make the code as universally working as possible.
Therefore I'd suggest completely removing ifupdown in order to simplify code and its future maintenance and increase its compatibility.
What do you think?
Fine by me. I don't have a Raspberry Pi to test with, but I assume the OS came with standard ifconfig? Change coming. |
Mmmmh seems like this could be a problem... |
So it looks like this is a can of worms. ifconfig has been deprecated for "ip", so maybe the way it is now is for the best. |
This might do the trick: |
I think that the pre-requisite check section of the script should find out which tools are available on the pc running it and use that information to let the automation work correctly without forcing the user to configure / change anything. In the meantime we can complete this merge since it contains many other nice features. |
So it seems that ifupdown isn't compatible with udev which I was reluctant to remove on my ReadyNAS OS. Not sure what huge value you get vs ifconfig (maybe the --force? option) but it was easy enough to make it optional.