Rename CRD file to reflect all KServe CRDs (Fixes #4396) #4494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
Signed-off-by: barkie <barkie.huang@gmail.com>
d2f7309 to
1d5e121
Compare
spolti
approved these changes
May 27, 2025
|
@WHITE-ICE-BOX The name need to be changed in the makefile as well. |
|
/hold |
|
@sivanantha321 Thanks for pointing that out! I’ll update the Makefile references and push the fix shortly. Much appreciated! 🙏 |
Signed-off-by: barkie <barkie.huang@gmail.com>
c4fff5f to
6d606ac
Compare
|
Hi @sivanantha321 @yuzisun , |
|
/unhold |
|
Thanks for the contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR renames the following test CRD file:
test/crds/serving.kserve.io_inferenceservices.yaml→
test/crds/serving.kserve.io_all_crds.yamlThe original file contains all CRDs used in KServe (including InferenceService, ClusterServingRuntime, InferenceGraph, etc.), not just InferenceService.
Renaming helps avoid confusion and improves clarity.
No functional changes are made.
Which issue(s) this PR fixes:
Fixes #4396
Type of changes
Feature/Issue validation/testing:
Manually verified that only filename was changed, contents remain identical.
git diffshows no changes other than file rename.Logs