Fix issue with precommit hook #4456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rerun-all |
1 similar comment
|
/rerun-all |
|
cc @hdefazio |
|
/lgtm |
|
Hi, I'm seeing the same e2e test failures on my draft pr #4455 so I think they are unrelated to this PR but something we should look into |
|
/rerun-all |
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net>
Signed-off-by: Dan Sun <dsun20@bloomberg.net>
yuzisun
approved these changes
May 10, 2025
openshift-merge-bot bot
pushed a commit
to opendatahub-io/kserve
that referenced
this pull request
May 22, 2025
* Improve Handling of Knative Autoscaler Confguration (kserve#4394) Signed-off-by: Brett Thompson <196701379+brettmthompson@users.noreply.github.com> * chore: adds CNCF Code of Conduct (kserve#4458) Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: Reenable Docker workflows to support arm64 build (kserve#4446) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Fix issue with precommit hook (kserve#4456) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Dan Sun <dsun20@bloomberg.net> * Fix raw deployment update (kserve#4445) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> * update golangcli-lint to 1.64.8 (kserve#4459) Signed-off-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> * fix: corrects links to translations (kserve#4461) Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com> * chore: Include third party licenses, Add license checker, Enable SBOM Generation for images (kserve#4416) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> * LMCache Integration with vLLM runtime (kserve#4320) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Publish 0.15.1 release (kserve#4466) Signed-off-by: Jin Dong <jdong183@bloomberg.net> * Fix: add type specification for nthread argument in argument parser (kserve#4410) Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Improve code coverage (kserve#4385) Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> * Fixes vLLM V1 failures: Revert back the approach to initiate the background engine task (kserve#4470) Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> * Fixes CVE-2025-43859 (kserve#4468) Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Andres Llausas <allausas@redhat.com> Co-authored-by: Andres Llausas <allausas@redhat.com> * replace t.context() with context.TODO() This is not available with go1.23 Signed-off-by: Spolti <fspolti@redhat.com> * use complete path for GOPATH/bin Signed-off-by: Spolti <fspolti@redhat.com> * Precommit run Signed-off-by: Spolti <fspolti@redhat.com> * Fix post sync tests Signed-off-by: Spolti <fspolti@redhat.com> --------- Signed-off-by: Brett Thompson <196701379+brettmthompson@users.noreply.github.com> Signed-off-by: Bartosz Majsak <bartosz.majsak@gmail.com> Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com> Signed-off-by: Dan Sun <dsun20@bloomberg.net> Signed-off-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com> Signed-off-by: Jin Dong <jdong183@bloomberg.net> Signed-off-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> Signed-off-by: Spolti <fspolti@redhat.com> Signed-off-by: Andres Llausas <allausas@redhat.com> Co-authored-by: Brett Thompson <196701379+brettmthompson@users.noreply.github.com> Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrews Arokiam <87992092+andyi2it@users.noreply.github.com> Co-authored-by: Dan Sun <dsun20@bloomberg.net> Co-authored-by: Abolfazl Shahbazi <12436063+ashahba@users.noreply.github.com> Co-authored-by: Jin Dong <greenmoon55@users.noreply.github.com> Co-authored-by: Gavrish Prabhu <gavrish.prabhu@nutanix.com> Co-authored-by: Andres Llausas <allausas@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix the precommit issue from the previous PR #4337
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all- rerun all failed workflows./rerun-workflow <workflow name>- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.