8000 fix: 4439 - update telepresence-setup.sh to adopt tooling changes by cjohannsen-cloudera · Pull Request #4440 · kserve/kserve · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: 4439 - update telepresence-setup.sh to adopt tooling changes #4440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

cjohannsen-cloudera
Copy link
@cjohannsen-cloudera cjohannsen-cloudera commented May 2, 2025

What this PR does / why we need it:

The telepresence debugging script is out-of-date and not currently functional. This PR adopts changes required to enable telepresence again.

Which issue(s) this PR fixes
Fixes #4439

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

  1. Run hack/telepresence-setup.sh
  2. Run the manager locally
  3. Issue an API request and observe that the local application intercepts the call

Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

Comment on lines +36 to +43
"allowPrivilegeEscalation": false,
"capabilities": {
"drop": ["ALL"]
},
"privileged": false,
"readOnlyRootFilesystem": true,
"runAsNonRoot": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzisun What is the best way to set the values when in debugging mode so that they are not applied otherwise?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is replacing the original settings that have to be modified to allow telepresense to run, back to the chart values that were present prior to starting debugging. If there's a simpler/cleaner way please let me know.

@sivanantha321
Copy link
Member

@cjohannsen-cloudera Can you help rebase ?

@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch from e9981c9 to afc8008 Compare May 13, 2025 16:29
@cjohannsen-cloudera
Copy link
Author

/rerun-all

@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch from 67a48fa to 7d12e47 Compare May 14, 2025 16:36
@cjohannsen-cloudera
Copy link
Author

/rerun-all

@cjohannsen-cloudera
Copy link
Author

/rerun-workflow test-raw
/rerun-workflow test-transformer-explainer-mms

@cjohannsen-cloudera
Copy link
Author
8000

/rerun-workflow test-transformer-explainer-mms

@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch 2 times, most recently from 468dc3e to 45c9ad0 Compare May 16, 2025 17:07
@cjohannsen-cloudera
Copy link
Author

/rerun-all

@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch 3 times, most recently from 3e9f560 to b0d4299 Compare May 28, 2025 16:37
@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch from b0d4299 to b1d7d32 Compare May 29, 2025 16:01
@cjohannsen-cloudera
Copy link
Author

/rerun-workflow test-predictor

8000
@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch 3 times, most recently from 1343a12 to 213037a Compare June 6, 2025 16:22
@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch 2 times, most recently from 26872ba to 1b32c18 Compare June 11, 2025 17:36
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
@cjohannsen-cloudera cjohannsen-cloudera force-pushed the cj/4439-telepresence-fix branch from 1b32c18 to f22a72d Compare June 12, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telepresence debugging not operational
3 participants
0