-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: 4439 - update telepresence-setup.sh to adopt tooling changes #4440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: 4439 - update telepresence-setup.sh to adopt tooling changes #4440
Conversation
"allowPrivilegeEscalation": false, | ||
"capabilities": { | ||
"drop": ["ALL"] | ||
}, | ||
"privileged": false, | ||
"readOnlyRootFilesystem": true, | ||
"runAsNonRoot": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are configurable from the helm chart
https://github.com/kserve/kserve/blob/master/charts/kserve-resources/values.yaml#L101
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuzisun What is the best way to set the values when in debugging mode so that they are not applied otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is replacing the original settings that have to be modified to allow telepresense to run, back to the chart values that were present prior to starting debugging. If there's a simpler/cleaner way please let me know.
@cjohannsen-cloudera Can you help rebase ? |
e9981c9
to
afc8008
Compare
/rerun-all |
67a48fa
to
7d12e47
Compare
/rerun-all |
/rerun-workflow test-raw |
8000
/rerun-workflow test-transformer-explainer-mms |
468dc3e
to
45c9ad0
Compare
/rerun-all |
3e9f560
to
b0d4299
Compare
b0d4299
to
b1d7d32
Compare
/rerun-workflow test-predictor |
1343a12
to
213037a
Compare
26872ba
to
1b32c18
Compare
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
Signed-off-by: cory-johannsen <cjohannsen@cloudera.com>
1b32c18
to
f22a72d
Compare
What this PR does / why we need it:
The telepresence debugging script is out-of-date and not currently functional. This PR adopts changes required to enable telepresence again.
Which issue(s) this PR fixes
Fixes #4439
Type of changes
Feature/Issue validation/testing:
hack/telepresence-setup.sh
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.