Tags: kschat/nock
Tags
fix: update Socket for Node 18 compat (nock#2467) In Node 18+, Write Stream detection has changed. We needed to add a dummy `write` method to our `Socket` class in order to avoid the following error: > The "stream" argument must be an instance of ReadableStream, WritableStream, or Stream. Received an instance of Socket The minimum requirements for SSL certs also increased, so I was forced to update our certs used in testing.
fix(dep): migrate from lodash.set to lodash. (nock#2306) Listing `lodash` as a prod dependency has a few advantages over the single func dep we were using. Primarily, when a security vulnerability is patched in LoDash, those changes don't get published to individual function libs anymore. The most recent example being the prototype pollution that was patched in 4.17.16. That particular vulnerability didn't effect Nock because of our usage, however, Nock does show up as having a vulnerability because of it which is a pain for consumers. It also creates a future problem where the next patch could affect Nock more directly. nock#2279 It should be noted that LoDash itself discourages the use of these single function libs: https://lodash.com/per-method-packages This changes also removes the vendor-izing of two LoDash functions in favor of using the lib directly (`isPlainObject` and `mapValues`).
PreviousNext