8000 Fix lint errors by DhairyaMajmudar · Pull Request #567 · kro-run/kro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix lint errors #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 4, 2025
Merged

Fix lint errors #567

merged 3 commits into from
Jun 4, 2025

Conversation

DhairyaMajmudar
Copy link
Contributor

Description

While running the command make lint there showed up several linting errors were made, This PR is focused on resolving those errors.

Screenshot from 2025-05-24 09-40-26

Copy link
Member
@barney-s barney-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

Copy link
Member
@barney-s barney-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

Copy link
Member
@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @DhairyaMajmudar ! left two comments in line

pkg/controller/instance/controller_reconcile.go Outdated Show resolved Hide resolved
@barney-s barney-s merged commit 35f9368 into kro-run:main Jun 4, 2025
4 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the lint-fix branch June 5, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0