8000 [Draft] Unify DateFormat and DateTimeSpanFormat to implement ISO8601 on top of it by soywiz · Pull Request #61 · korlibs/korlibs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Draft] Unify DateFormat and DateTimeSpanFormat to implement ISO8601 on top of it #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

[Draft] Unify DateFormat and DateTimeSpanFormat to implement ISO8601 on top of it #61

wants to merge 9 commits into from

Conversation

soywiz
Copy link
Contributor
@soywiz soywiz commented May 14, 2024

No description provided.

@soywiz soywiz changed the title Unify DateFormat and DateTimeSpanFormat to implement ISO8601 on top of it [Draft] Unify DateFormat and DateTimeSpanFormat to implement ISO8601 on top of it May 14, 2024
@soywiz
Copy link
Contributor Author
soywiz commented May 14, 2024

This is still an experiment. Not sure I like some parts. So I will probably discard it but will keep some stuff that worked nice while working on it

@soywiz
Copy link
Contributor Author
soywiz commented May 14, 2024 •
edited
Loading

Things I want to cherry pick:

  • Remove withOptional
  • Being able to parse stuff to DateComponents. Maybe with a new interface. Then adapt that interface to the two interfaces regarding parsing.
  • Create and adapt DateTimeSpanFormat to internally use DateComponents
  • Refactor ISO parsing to do analogously to DateComponentsFormat
  • Extract ComputedTime
  • Extra methods frrom ComputedTime and DateTimeSpan
  • Replace old TimeSpan with Duration

This was referenced May 15, 2024
Merged
Merged
@soywiz soywiz marked this pull request as draft May 15, 2024 07:57
This was referenced May 15, 2024
Merged
Merged
Merged
Merged
Merged
@soywiz soywiz closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soywiz
0